-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): switch to upstream #4319
Conversation
WalkthroughRecent modifications focus on updating dependencies to enhance compatibility and functionality. The primary changes involve altering the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Cargo.toml (1 hunks)
Additional comments not posted (2)
Cargo.toml (2)
118-118
: Approved: Update to stable version ofetcd-client
.The change from a specific git revision to version
0.13
ensures the use of a stable version. Verify compatibility with the project.
122-122
: Approved: Update to new repository forgreptime-proto
.The change to point to a new git repository and a specific new revision ensures the use of an updated version. Verify the integrity and compatibility of the new repository and revision.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4319 +/- ##
==========================================
- Coverage 85.16% 85.14% -0.03%
==========================================
Files 1061 1061
Lines 188255 188255
==========================================
- Hits 160330 160290 -40
- Misses 27925 27965 +40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The |
Signed-off-by: tison <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (1)
- src/api/Cargo.toml (1 hunks)
Files skipped from review due to trivial changes (1)
- src/api/Cargo.toml
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
TRIVIAL AS IS
Checklist
Summary by CodeRabbit
etcd-client
to version0.13
for improved compatibility.greptime-proto
dependency to a new repository for better reliability.tonic-build
from version "0.9" to "0.11" for enhanced build performance.