Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): switch to upstream #4319

Merged
merged 2 commits into from
Jul 9, 2024
Merged

build(deps): switch to upstream #4319

merged 2 commits into from
Jul 9, 2024

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Jul 8, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

TRIVIAL AS IS

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Summary by CodeRabbit

  • Chores
    • Updated etcd-client to version 0.13 for improved compatibility.
    • Changed greptime-proto dependency to a new repository for better reliability.
    • Upgraded tonic-build from version "0.9" to "0.11" for enhanced build performance.

@tisonkun tisonkun requested a review from a team as a code owner July 8, 2024 21:02
Copy link
Contributor

coderabbitai bot commented Jul 8, 2024

Walkthrough

Recent modifications focus on updating dependencies to enhance compatibility and functionality. The primary changes involve altering the Cargo.toml files: switching the etcd-client dependency to version 0.13, updating greptime-proto to a new git repository with a specific revision, and upgrading tonic-build from "0.9" to "0.11" in the build dependencies. These updates ensure better performance and maintainability of the project.

Changes

File Change Summary
Cargo.toml Update etcd-client to version 0.13 and greptime-proto to a new git revision
src/api/Cargo.toml Update tonic-build version from "0.9" to "0.11"

Poem

In the realm where code does spark,

Dependencies dance, embark!

Version jump from nine to eleven,

Tonic sings with builds at seven.

Etcd now more robust in nature,

Proto from a fresh adventure.

Coding fields, the future is bright,

Upgrades done right, taking flight! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jul 8, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0030821 and b174eeb.

Files selected for processing (1)
  • Cargo.toml (1 hunks)
Additional comments not posted (2)
Cargo.toml (2)

118-118: Approved: Update to stable version of etcd-client.

The change from a specific git revision to version 0.13 ensures the use of a stable version. Verify compatibility with the project.


122-122: Approved: Update to new repository for greptime-proto.

The change to point to a new git repository and a specific new revision ensures the use of an updated version. Verify the integrity and compatibility of the new repository and revision.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (0030821) to head (da1a916).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4319      +/-   ##
==========================================
- Coverage   85.16%   85.14%   -0.03%     
==========================================
  Files        1061     1061              
  Lines      188255   188255              
==========================================
- Hits       160330   160290      -40     
- Misses      27925    27965      +40     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Contributor

The Cargo.lock needs to be updated. @tisonkun

Signed-off-by: tison <[email protected]>
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b174eeb and da1a916.

Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing (1)
  • src/api/Cargo.toml (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/api/Cargo.toml

@tisonkun tisonkun added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit d1f1fad Jul 9, 2024
55 checks passed
@tisonkun tisonkun deleted the tisonkun-patch-1 branch July 9, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants