-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: retry on error during installing operator #4295
Conversation
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/actions/setup-greptimedb-cluster/action.yml (1 hunks)
Additional comments not posted (5)
.github/actions/setup-greptimedb-cluster/action.yml (5)
34-49
: LGTM! The retry mechanism is correctly implemented.The retry mechanism using
nick-fields/retry@v3
is correctly configured with appropriate parameters. The encapsulated shell script for installing the GreptimeDB operator is also correct.
Line range hint
50-70
:
Ensure compatibility with the retry mechanism.The installation steps for the GreptimeDB cluster look correct. However, consider adding a retry mechanism for this step as well to ensure robustness.
Line range hint
71-83
:
Efficient waiting mechanism.The loop correctly waits for the GreptimeDB cluster to be ready by checking the cluster phase every 5 seconds and printing the current phase and pod status.
Line range hint
84-88
:
Useful debugging step.The step to print all resources in the GreptimeDB namespace with their labels is useful for debugging and ensuring the cluster is correctly set up.
Line range hint
89-93
:
Useful debugging step.The step to describe the nodes in the Kubernetes cluster is useful for debugging and ensuring the nodes are correctly configured.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4295 +/- ##
==========================================
- Coverage 85.31% 85.02% -0.29%
==========================================
Files 1063 1063
Lines 188345 188508 +163
==========================================
- Hits 160686 160285 -401
- Misses 27659 28223 +564 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Retry on error during installing operator
Checklist
Summary by CodeRabbit