-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fulltext_index): introduce creator #4249
Conversation
Signed-off-by: Zhenchi <[email protected]>
Note Reviews pausedUse the following commands to manage reviews:
WalkthroughThis change set introduces a new fulltext indexing feature leveraging the Tantivy search engine. It includes configuration, creation, and error handling functionalities. Dependencies such as Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Signed-off-by: Zhenchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 6
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (8)
- src/index/Cargo.toml (1 hunks)
- src/index/src/fulltext_index.rs (1 hunks)
- src/index/src/fulltext_index/create.rs (1 hunks)
- src/index/src/fulltext_index/create/tantivy.rs (1 hunks)
- src/index/src/fulltext_index/error.rs (1 hunks)
- src/index/src/lib.rs (1 hunks)
- src/puffin/src/puffin_manager/stager/bounded_stager.rs (1 hunks)
- src/puffin/src/puffin_manager/tests.rs (9 hunks)
Files skipped from review due to trivial changes (1)
- src/puffin/src/puffin_manager/tests.rs
Additional context used
GitHub Check: Check typos and docs
src/index/src/fulltext_index/create/tantivy.rs
[warning] 33-33:
"maximun" should be "maximum".
Additional comments not posted (6)
src/index/src/lib.rs (1)
17-17
: Verify the necessity of the feature flag.The feature flag
iter_partition_in_place
is enabled. Ensure it is necessary for the functionality introduced in this module.src/index/Cargo.toml (1)
27-31
: Verify the appropriateness of new dependencies.Ensure that the versions and features of the new dependencies (
serde
,tantivy
,tantivy-jieba
,tokio
, andcommon-test-util
) are appropriate for the functionality introduced.Also applies to: 34-34
src/index/src/fulltext_index.rs (1)
1-37
: LGTM! The new module for fulltext indexing is well-defined.The
Config
struct andAnalyzer
enum are correctly implemented withserde
for serialization/deserialization and theDefault
trait.src/index/src/fulltext_index/create.rs (1)
1-33
: LGTM! TheFulltextIndexCreator
trait and its implementation are well-defined.The trait and its methods are correctly implemented with appropriate async traits. The module structure is clear and organized.
src/index/src/fulltext_index/create/tantivy.rs (1)
122-315
: Comprehensive Unit TestsThe unit tests for
TantivyFulltextIndexCreator
are comprehensive and cover various configurations and edge cases. This is a good practice to ensure the robustness of the implementation.src/puffin/src/puffin_manager/stager/bounded_stager.rs (1)
70-70
: Typographical Error: "capicity" should be "capacity"There is a typographical error in the function parameter.
-pub async fn new(base_dir: PathBuf, capicity: u64) -> Result<Self> { +pub async fn new(base_dir: PathBuf, capacity: u64) -> Result<Self> {Likely invalid or redundant comment.
Signed-off-by: Zhenchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, index master
@coderabbitai pause |
Actions performedReviews paused. |
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4249 +/- ##
==========================================
- Coverage 85.00% 84.71% -0.29%
==========================================
Files 1051 1054 +3
Lines 186627 186950 +323
==========================================
- Hits 158636 158371 -265
- Misses 27991 28579 +588 |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#4246
What's changed and what's your intention?
as @coderabbitai
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
capicity
tocapacity
in various functions and tests to ensure consistency and prevent errors.Error Handling