refactor: add region_dir in CompactionRegion

[zyy17]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add region_dir in CompactionRegion.

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

Summary by CodeRabbit

• New Features
  • Improved compaction process by adding region_dir field to better manage region directories.

[coderabbitai]

Walkthrough

In the CompactionScheduler implementation in compaction.rs, a new field region_dir has been introduced to the CompactionRegion struct. This field is populated with the value obtained from access_layer.region_dir().to_string(). Additionally, the field assignments within the open_compaction_region function have been reordered.

Changes

File	Change Summary
src/mito2/src/compaction.rs	Added region_dir: String field to CompactionRegion struct. Reordered field assignments in open_compaction_region function.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CompactionScheduler
    participant AccessLayer
    participant CompactionRegion

    User ->> CompactionScheduler: Initiate compaction
    CompactionScheduler ->> AccessLayer: Retrieve region_dir
    AccessLayer -->> CompactionScheduler: region_dir value
    CompactionScheduler ->> CompactionRegion: new(region_dir)

Loading

Poem

🐇 Amidst the code where changes gleam,
A region_dir joins the team,
In compaction dance, it finds its place,
With reordered steps, it sets the pace.
Oh, how it brings a fresh new scheme,
For files to follow, and data's dream. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

src/mito2/src/compaction/compactor.rs (1)

56-56: Add documentation for the new field region_dir.

The new field region_dir in CompactionRegion should have a documentation comment to explain its purpose and usage, especially since it is a public field.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5566dd7 and 1d57f2a.

Files selected for processing (2)

• src/mito2/src/compaction.rs (1 hunks)
• src/mito2/src/compaction/compactor.rs (2 hunks)

Additional comments not posted (1)

src/mito2/src/compaction.rs (1)

279-279: Ensure region_dir is correctly derived from access_layer.

The new field region_dir in CompactionRegion is derived from access_layer.region_dir().to_string(). It's crucial to ensure that access_layer always has a valid region_dir before this assignment to prevent potential errors.

[codecov]

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.80%. Comparing base (1e52ba3) to head (1d57f2a).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4187      +/-   ##
==========================================
- Coverage   85.04%   84.80%   -0.25%     
==========================================
  Files        1027     1028       +1     
  Lines      180210   180479     +269     
==========================================
- Hits       153258   153049     -209     
- Misses      26952    27430     +478     

[v0y4g3r]

LGTM