Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dedup strategy that keeps the last not null field #4184

Merged
merged 10 commits into from
Jun 25, 2024
Merged

feat: Dedup strategy that keeps the last not null field #4184

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b811d3
feat: dedup strategy: last not null
evenyag Jun 20, 2024
d88fe87
fix: fix tests
evenyag Jun 20, 2024
116f45c
fix: fix single batch
evenyag Jun 20, 2024
8b3b656
chore: warning
evenyag Jun 20, 2024
1221fef
chore: skip has_null check
evenyag Jun 21, 2024
799f11f
refactor: rename fields
evenyag Jun 21, 2024
211a371
fix: merge last fields may not reset builder
evenyag Jun 24, 2024
a669248
chore: clear before filter deleted
evenyag Jun 24, 2024
8b90a08
chore: remove debug logs
evenyag Jun 25, 2024
f95fc79
chore: Update comment
evenyag Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: Update comment 
Co-authored-by: Ruihang Xia <[email protected]>
  • Loading branch information
@evenyag @waynexia
evenyag and waynexia committed Jun 25, 2024
commit f95fc799a8f6f11ba9bc6152a1b4dcdf29a95b3e
2 changes: 1 addition & 1 deletion src/mito2/src/read/dedup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ impl LastFieldsBuilder {
}
};

// Resets itself. `self.builders` already reset in `to_vector()`.
// Resets itself. `self.builders` is already reset in `to_vector()`.
self.clear();

if self.filter_deleted {
Expand Down