perf: optimize RecordBatch to HttpOutput conversion #4178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Optimize
HttpRecordsOutput::try_new()
method. Reduce the consumption of converting 409600 rows from ~400ms to ~120ms. Saves ~70% CPU.This patch also adds a microbenchmark for that method.
Key optimizations are:
Value::String
fromBytes
toString
Clone
sNow the entire conversion method only has one
clone
that takes data from the data vector, and onewrite
that writes the serialized content to the result vector.Checklist