Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: region logical regions after catching up #4176

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 20, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR registers metric logical regions after invoking catchup and fixes metric logical regions not found issues after migrating a physical region.

After replaying the WAL of a metric metadata region, there are two places required to register logical regions manually:

  • Metric engine
  • RegionServer

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested review from waynexia and a team as code owners June 20, 2024 06:29
@WenyXu WenyXu requested a review from fengjiachun June 20, 2024 06:29
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 20, 2024
@WenyXu WenyXu force-pushed the fix/metric-table-migration branch from efdb6a8 to 24f2f2e Compare June 20, 2024 06:37
@WenyXu WenyXu force-pushed the fix/metric-table-migration branch from 24f2f2e to e986c0c Compare June 20, 2024 06:56
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (4306cba) to head (e986c0c).
Report is 5 commits behind head on main.

Current head e986c0c differs from pull request most recent head 62b886d

Please upload reports for the commit 62b886d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4176      +/-   ##
==========================================
- Coverage   85.12%   84.86%   -0.27%     
==========================================
  Files        1022     1022              
  Lines      179843   179859      +16     
==========================================
- Hits       153094   152631     -463     
- Misses      26749    27228     +479     

@killme2008
Copy link
Contributor

@WenyXu Please describe the PR in detail. What issue does it address? What happened before this patch etc.

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu added this pull request to the merge queue Jun 21, 2024
Merged via the queue into GreptimeTeam:main with commit 15ad9f2 Jun 21, 2024
48 checks passed
@WenyXu WenyXu deleted the fix/metric-table-migration branch June 21, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants