Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enhance add pipeline http api return data #4167

Merged
merged 2 commits into from
Jun 20, 2024
Merged

chore: enhance add pipeline http api return data #4167

merged 2 commits into from
Jun 20, 2024

Conversation

paomian
Copy link
Contributor

@paomian paomian commented Jun 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Making "add pipeline" http API return more info about added pipeline.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 18, 2024
@paomian paomian marked this pull request as ready for review June 18, 2024 13:41
@paomian paomian requested a review from a team as a code owner June 18, 2024 13:41
@paomian paomian requested a review from sunng87 June 18, 2024 13:48
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (ea2d067) to head (44c5f88).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4167      +/-   ##
==========================================
- Coverage   85.16%   84.82%   -0.34%     
==========================================
  Files        1021     1020       -1     
  Lines      179241   179654     +413     
==========================================
- Hits       152650   152397     -253     
- Misses      26591    27257     +666

killme2008
killme2008 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shuiyisong
shuiyisong reviewed Jun 19, 2024
View reviewed changes
src/pipeline/src/manager/table.rs Show resolved Hide resolved
src/servers/src/http/event.rs Outdated Show resolved Hide resolved
src/servers/src/http/event.rs Show resolved Hide resolved
@shuiyisong shuiyisong added this pull request to the merge queue Jun 20, 2024
Merged via the queue into GreptimeTeam:main with commit 48a0f39 Jun 20, 2024
49 checks passed
zyy17 pushed a commit to zyy17/greptimedb that referenced this pull request Jun 22, 2024
@paomian @zyy17
chore: enhance add pipeline http api return data (GreptimeTeam#4167)
2c2d417 
* chore: enhance add pipeline http api return data

* chore: replaceing hard code header value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 approved these changes

@shuiyisong shuiyisong shuiyisong approved these changes

@evenyag evenyag Awaiting requested review from evenyag

@sunng87 sunng87 Awaiting requested review from sunng87

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paomian @killme2008 @shuiyisong