Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register flow node #4166

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Jun 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR:

  1. Refactor datanode keys
  2. Keep flownode's lease info in metasrv leader
  3. Flownode selector

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 74.35897% with 70 lines in your changes missing coverage. Please review.

Project coverage is 84.84%. Comparing base (ea2d067) to head (42cb006).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4166      +/-   ##
==========================================
- Coverage   85.16%   84.84%   -0.33%     
==========================================
  Files        1021     1022       +1     
  Lines      179241   179735     +494     
==========================================
- Hits       152650   152489     -161     
- Misses      26591    27246     +655     

@fengjiachun fengjiachun marked this pull request as draft June 18, 2024 13:19
@fengjiachun fengjiachun marked this pull request as ready for review June 19, 2024 04:33
@fengjiachun fengjiachun requested a review from a team as a code owner June 19, 2024 04:33
@fengjiachun fengjiachun requested review from waynexia, WenyXu, discord9 and zyy17 and removed request for MichaelScofield June 19, 2024 04:34
@fengjiachun fengjiachun force-pushed the feat/register-flownode branch 2 times, most recently from 62e610a to 596da42 Compare June 19, 2024 05:45
@discord9 discord9 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into GreptimeTeam:main with commit 4c3d4af Jun 20, 2024
49 checks passed
@fengjiachun fengjiachun deleted the feat/register-flownode branch June 20, 2024 04:18
zyy17 pushed a commit to zyy17/greptimedb that referenced this pull request Jun 22, 2024
* feat: rename keys.rs to key.rs

* feat: refactor datanode keys

* feat: add flownode key

* feat: keep flownode's lease info in metasrv

* feat: flow selector

* feat: impl_try_from_lease_key and impl_from_str_lease_key to simple code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants