feat: register flow node #4166
Merged
feat: register flow node #4166
+516
−268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4166 +/- ##
==========================================
- Coverage 85.16% 84.84% -0.33%
==========================================
Files 1021 1022 +1
Lines 179241 179735 +494
==========================================
- Hits 152650 152489 -161
- Misses 26591 27246 +655 |
This was referenced Jun 18, 2024
fengjiachun
requested review from
waynexia,
WenyXu,
discord9 and
zyy17
and removed request for
MichaelScofield
fengjiachun
force-pushed
the
feat/register-flownode
branch
from
7ba91ed
to
fbe9ae7
Compare
fengjiachun
force-pushed
the
feat/register-flownode
branch
2 times, most recently
from
62e610a
to
596da42
Compare
fengjiachun
force-pushed
the
feat/register-flownode
branch
from
596da42
to
42cb006
Compare
WenyXu
approved these changes
Jun 20, 2024
discord9
approved these changes
Jun 20, 2024
zyy17
pushed a commit
to zyy17/greptimedb
that referenced
this pull request
Jun 22, 2024
* feat: rename keys.rs to key.rs * feat: refactor datanode keys * feat: add flownode key * feat: keep flownode's lease info in metasrv * feat: flow selector * feat: impl_try_from_lease_key and impl_from_str_lease_key to simple code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR:
Checklist