Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable metasrv to accept flownode's heartbeats #4160

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat: enable metasrv to accept flownode's heartbeats #4160

merged 2 commits into from
Jun 18, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said, in additional, we can also get flow node's cluster info

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@fengjiachun fengjiachun requested review from MichaelScofield and a team as code owners June 17, 2024 13:40
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 17, 2024
fengjiachun
fengjiachun commented Jun 17, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@fengjiachun fengjiachun mentioned this pull request Jun 17, 2024
Open
4 tasks
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 3.44828% with 28 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (0fc18b6) to head (992d3f4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4160      +/-   ##
==========================================
- Coverage   84.92%   84.63%   -0.30%     
==========================================
  Files        1023     1023              
  Lines      179298   179317      +19     
==========================================
- Hits       152272   151761     -511     
- Misses      27026    27556     +530

zyy17
zyy17 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jun 18, 2024
Merged via the queue into GreptimeTeam:main with commit 141d017 Jun 18, 2024
28 of 49 checks passed
@fengjiachun fengjiachun deleted the feat/metasrv-flow-heartbeat branch June 18, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

@WenyXu WenyXu WenyXu approved these changes

@discord9 discord9 discord9 approved these changes

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield MichaelScofield is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fengjiachun @zyy17 @WenyXu @discord9