Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pipeline): join processor #4158

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Porting https://github.com/GreptimeTeam/pipeline/pull/44

Implement join processor

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@shuiyisong shuiyisong requested a review from a team as a code owner June 17, 2024 09:09
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 17, 2024
@shuiyisong shuiyisong requested a review from paomian June 17, 2024 09:09
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 76.25000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 84.62%. Comparing base (0fc18b6) to head (df7a9ea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4158      +/-   ##
==========================================
- Coverage   84.92%   84.62%   -0.31%     
==========================================
  Files        1023     1024       +1     
  Lines      179298   179378      +80     
==========================================
- Hits       152272   151791     -481     
- Misses      27026    27587     +561     

src/pipeline/src/etl/processor/join.rs Show resolved Hide resolved
src/pipeline/tests/join.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuiyisong shuiyisong added this pull request to the merge queue Jun 18, 2024
Merged via the queue into GreptimeTeam:main with commit cb657ae Jun 18, 2024
49 checks passed
@shuiyisong shuiyisong deleted the feat/join_processor branch June 18, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants