Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlness): catch different format timestamp #4149

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 15, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #4148

What's changed and what's your intention?

This PR tries to catch different format timestamps in the sqlness case(introduced in #3832); The format of output timestamps may behave inconsistently on different platforms. (e.g., 20240615T04:24:18, 2024-04-30T06:40:02.074)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner June 15, 2024 05:45
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 15, 2024
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (bf3ad44) to head (85ae05e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4149      +/-   ##
==========================================
- Coverage   85.45%   84.66%   -0.79%     
==========================================
  Files         994     1018      +24     
  Lines      174907   178688    +3781     
==========================================
+ Hits       149470   151295    +1825     
- Misses      25437    27393    +1956     

@evenyag evenyag added this pull request to the merge queue Jun 15, 2024
Merged via the queue into GreptimeTeam:main with commit d6392ac Jun 15, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sqlness tests failed
3 participants