Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use ld_classic on macOS #4143

Merged
merged 1 commit into from
Jun 14, 2024
Merged

fix(ci): use ld_classic on macOS #4143

merged 1 commit into from
Jun 14, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jun 14, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

rust-lang/rust#113783

What's changed and what's your intention?

The PR use ld_classic on macOS when releasing macOS artifact.

The latest macOS CI runner image(https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240611.1), its default linker can't get the backtraces properly, which will lead release failed.

thread 'selector::weighted_choose::tests::test_random_reverse_weighted_choose_should_panic' panicked at src/meta-srv/src/selector/weighted_choose.rs:173:41:
called `Result::unwrap()` on an `Err` value: 0: Failed to set weight array, at src/meta-srv/src/selector/weighted_choose.rs:87:18
1: NoItem
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
libunwind: stepWithCompactEncoding - invalid compact unwind encoding

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner June 14, 2024 07:23
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.48%. Comparing base (54ca06b) to head (0f29c9c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4143      +/-   ##
==========================================
+ Coverage   85.46%   85.48%   +0.01%     
==========================================
  Files         994      994              
  Lines      174907   174907              
==========================================
+ Hits       149489   149514      +25     
+ Misses      25418    25393      -25     

@WenyXu
Copy link
Member Author

WenyXu commented Jun 14, 2024

@WenyXu
Copy link
Member Author

WenyXu commented Jun 14, 2024

@shuiyisong shuiyisong self-requested a review June 14, 2024 08:08
@WenyXu WenyXu added this pull request to the merge queue Jun 14, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into main with commit acdfaab Jun 14, 2024
61 checks passed
@WenyXu WenyXu deleted the debug-mac-runner branch June 14, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants