fix: macro crate cannot be compiled alone #4130
Merged
+131
−139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This patch fixes an issue that I came across while working on other modules sit in common. Our
macro
module cannot compile by itself.The macro module depends on both syn 1.0 and syn 2.0. I have no idea why it works but it turns out working when you compile the whole thing from root level.
This patch completely removed usage of syn 1.0 from
macros
, upgraded tosyn::meta::parser
for getting attributes. It also changes data type of those macro attribute value from string literal to ident, because it's actually used as ident.Checklist