feat: PREPARE and EXECUTE statement from mysql client

[CookiePieWw]

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #769

What's changed and what's your intention?

As title.

Checklist

• I have written the necessary rustdoc comments.
• I have added the necessary unit tests and integration tests.
• This PR requires documentation updates.

[CookiePieWw]

Now it works on some simple cases I tried. For PREPARE stmt and on_prepare I tried to extract common logic into do_prepare. It's quite similar in EXECUTE stmt and on_execute, but I find it a little tricky for the writer and different parameter types (ParamParser for on_execute and Expr for the stmt). Maybe I could refactor it later.

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 138 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (cc2f7ef) to head (5e33b1f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4125      +/-   ##
==========================================
- Coverage   85.12%   84.82%   -0.31%     
==========================================
  Files        1020     1023       +3     
  Lines      179635   179907     +272     
==========================================
- Hits       152920   152610     -310     
- Misses      26715    27297     +582     

[killme2008]

Now it works on some simple cases I tried. For PREPARE stmt and on_prepare I tried to extract common logic into do_prepare. It's quite similar in EXECUTE stmt and on_execute, but I find it a little tricky for the writer and different parameter types (ParamParser for on_execute and Expr for the stmt). Maybe I could refactor it later.

Cool, let's take a look! Thank you. @MichaelScofield @fengjiachun

[killme2008]

Leave some suggestions and questions, please take a look.

I found that there are not enough tests currently, especially the unit tests, could you add some?

Thank you, it looks great!

[CookiePieWw]

Leave some suggestions and questions, please take a look.

Got it. I'll make some changes later.

I found that there are not enough tests currently, especially the unit tests, could you add some?

Sure. I'll try to add some sqlness tests as well, maybe copy some from duckdb :)

[CookiePieWw]

Changes have been done. The stmt_key is now an uuid string generated from stmt_id, so the StmtKey enum has been removed.

Since this only works for mysql client, I didn't find a way to add sqlness test for it. Maybe we can only test it manually.

Fuzz test on inserting logical table failed on some reason. Don't know if it's related to this pr. The log is similar to #4122:

2024-06-15T19:02:41.7471713Z 1: Database(MySqlDatabaseError { code: Some("HY000"), number: 1815, message: "Region 4432406249472(1032, 0) is in ReadOnly state, expect: Writable" })

[killme2008]

Since this only works for mysql client, I didn't find a way to add sqlness test for it. Maybe we can only test it manually.

We can leave it in the next PR. Let's figure out how to test it in sqlness. Currently you can test it at

greptimedb/tests-integration/tests/sql.rs

Line 135 in a2e3532

pub async fn test_mysql_crud(store_type: StorageType) {

Fuzz test on inserting logical table failed on some reason. Don't know if it's related to this pr. The log is similar to #4122:

2024-06-15T19:02:41.7471713Z 1: Database(MySqlDatabaseError { code: Some("HY000"), number: 1815, message: "Region 4432406249472(1032, 0) is in ReadOnly state, expect: Writable" })

Could you rebase the branch with the main? Looks like it's fixed already.

[killme2008]

It's almost done, thank you so much! @CookiePieWw

Please take a look @MichaelScofield

[CookiePieWw]

Updated and added DEALLOCATE stmt. PTAL @killme2008 @MichaelScofield

[killme2008]

Great work! Thanks a lot.

[killme2008]

@CookiePieWw Appreciate your contribution, thanks a lot.

[tisonkun]

@CookiePieWw Thanks for your contribution! Would you share your email address to me (by email to [email protected])?

I'd like to send you a letter for further engagement :D