Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flow): mfp operator missing rows #4084

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

discord9
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

fix a bug that mfp operator will missing rows if run multiple tims in same tick

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • fix a bug that mfp operator will missing rows if run multiple tims in same tick
  • add related tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (d1838fb) to head (53a7b55).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4084      +/-   ##
==========================================
- Coverage   85.49%   85.17%   -0.33%     
==========================================
  Files         991      991              
  Lines      173091   173142      +51     
==========================================
- Hits       147988   147477     -511     
- Misses      25103    25665     +562     

@killme2008 killme2008 added C-bug Category Bugs A-flow Involves code in DataFlow labels May 31, 2024
@killme2008
Copy link
Contributor

Can we test it?

@discord9
Copy link
Contributor Author

discord9 commented Jun 3, 2024

Can we test it?

Unit test are added, but since this bug is not quite yet suitable to be tested using sqlness/tests-intergation crate because it require above certain qps to be triggered, is considering modify tsbs or add a extra script/repo to test it

@discord9 discord9 marked this pull request as draft June 3, 2024 09:53
@discord9
Copy link
Contributor Author

discord9 commented Jun 4, 2024

flow doesn't work real well with sqlness since it's kind of async-ish, and can't update to dest table fast enough before sqlness deem test are done, currently working on that, meanwhile I'm using a python script to locally test flow's functionality

@discord9 discord9 marked this pull request as ready for review June 4, 2024 08:11
@discord9 discord9 added this pull request to the merge queue Jun 4, 2024
Merged via the queue into GreptimeTeam:main with commit 0a07130 Jun 4, 2024
28 checks passed
@discord9 discord9 deleted the flow_fix_mfp_missing branch June 4, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-flow Involves code in DataFlow C-bug Category Bugs docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants