Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display error in correct format #4082

Merged
merged 2 commits into from
May 31, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Change all error! usage without debug formatter on Error.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@waynexia waynexia requested review from zhongzc and a team as code owners May 31, 2024 08:38
@waynexia waynexia requested a review from fengjiachun May 31, 2024 08:38
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 31, 2024
@waynexia waynexia enabled auto-merge May 31, 2024 08:42
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 85.23%. Comparing base (fcfcf86) to head (9034e02).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4082      +/-   ##
==========================================
- Coverage   85.53%   85.23%   -0.31%     
==========================================
  Files         991      991              
  Lines      172933   172931       -2     
==========================================
- Hits       147925   147400     -525     
- Misses      25008    25531     +523     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue May 31, 2024
@evenyag evenyag removed this pull request from the merge queue due to a manual request May 31, 2024
@waynexia waynexia enabled auto-merge May 31, 2024 09:08
@waynexia waynexia added this pull request to the merge queue May 31, 2024
Merged via the queue into GreptimeTeam:main with commit 45fee94 May 31, 2024
28 checks passed
@waynexia waynexia deleted the tweak-error-code-3 branch May 31, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants