Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add tailing separator to prefix #4078

Merged
merged 2 commits into from
May 30, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

add tailing separator to prefix, otherwise it cannot handle when one schema name is a substring of another.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@waynexia waynexia requested review from MichaelScofield and a team as code owners May 30, 2024 12:58
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 30, 2024
@waynexia waynexia enabled auto-merge May 30, 2024 13:02
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.05%. Comparing base (0575108) to head (dc83970).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4078      +/-   ##
==========================================
- Coverage   85.35%   85.05%   -0.31%     
==========================================
  Files         987      987              
  Lines      172119   172141      +22     
==========================================
- Hits       146908   146409     -499     
- Misses      25211    25732     +521     

Signed-off-by: Ruihang Xia <[email protected]>
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue May 30, 2024
Merged via the queue into GreptimeTeam:main with commit 85a2318 May 30, 2024
28 checks passed
@waynexia waynexia deleted the fix-table-prefix branch May 30, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants