Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement SHOW STATUS #4050

Merged
merged 6 commits into from
May 29, 2024
Merged

feat: Implement SHOW STATUS #4050

merged 6 commits into from
May 29, 2024

Conversation

LYZJU2019
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4017

What's changed and what's your intention?

Implement "show status" feature. Currently return empty content.

image

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@LYZJU2019 LYZJU2019 requested review from evenyag and a team as code owners May 27, 2024 05:51
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 85.02%. Comparing base (aafb468) to head (a622d61).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4050      +/-   ##
==========================================
- Coverage   85.33%   85.02%   -0.31%     
==========================================
  Files         987      987              
  Lines      171224   171249      +25     
==========================================
- Hits       146106   145611     -495     
- Misses      25118    25638     +520     

src/query/src/sql.rs Outdated Show resolved Hide resolved
src/query/src/sql.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu added this pull request to the merge queue May 29, 2024
Merged via the queue into GreptimeTeam:main with commit f0effd2 May 29, 2024
28 checks passed
@LYZJU2019 LYZJU2019 deleted the show_status branch May 29, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants