Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): upgrade promql-parser to 0.4 #4047

Merged
merged 4 commits into from
May 27, 2024
Merged

build(deps): upgrade promql-parser to 0.4 #4047

merged 4 commits into from
May 27, 2024

Conversation

tisonkun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Eat the dog food.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@tisonkun tisonkun requested review from waynexia, evenyag and a team as code owners May 26, 2024 15:13
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 26, 2024
@tisonkun
catch up upgrades
4182d10 
Signed-off-by: tison <[email protected]>
@codecov Codecov
Copy link

codecov bot commented May 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 85.13%. Comparing base (5df3d4e) to head (3f1bac2).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4047      +/-   ##
==========================================
- Coverage   85.42%   85.13%   -0.30%     
==========================================
  Files         983      983              
  Lines      170493   170504      +11     
==========================================
- Hits       145652   145158     -494     
- Misses      24841    25346     +505

waynexia
waynexia approved these changes May 26, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge May 26, 2024 17:02
yuanbohan
yuanbohan approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@yuanbohan yuanbohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun
concise method
3f1bac2 
Signed-off-by: tison <[email protected]>
@waynexia waynexia added this pull request to the merge queue May 27, 2024
Merged via the queue into GreptimeTeam:main with commit 3790020 May 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@yuanbohan yuanbohan yuanbohan approved these changes

@killme2008 killme2008 Awaiting requested review from killme2008

@evenyag evenyag Awaiting requested review from evenyag evenyag is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tisonkun @yuanbohan @waynexia