Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: invoke flush_table and compact_table in fuzz tests #4045

Merged
merged 4 commits into from
May 27, 2024
Merged

feat: invoke flush_table and compact_table in fuzz tests #4045

merged 4 commits into from
May 27, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 26, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #4046

What's changed and what's your intention?

Invoke flush_table and compact_table in fuzz tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested a review from a team as a code owner May 26, 2024 10:54
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 26, 2024
@WenyXu WenyXu mentioned this pull request May 26, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented May 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.75000% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 85.10%. Comparing base (20ce7d4) to head (9395413).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4045      +/-   ##
==========================================
- Coverage   85.43%   85.10%   -0.33%     
==========================================
  Files         985      985              
  Lines      170515   170556      +41     
==========================================
- Hits       145687   145160     -527     
- Misses      24828    25396     +568

@WenyXu WenyXu requested a review from waynexia as a code owner May 26, 2024 11:18
killme2008
killme2008 reviewed May 27, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

tests-fuzz/targets/fuzz_insert_logical_table.rs Show resolved Hide resolved
fengjiachun
fengjiachun approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu force-pushed the feat/add-flush-compact-in-fuzz-tests branch from 13e9d68 to 9395413 Compare May 27, 2024 08:28
evenyag
evenyag approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue May 27, 2024
Merged via the queue into GreptimeTeam:main with commit 048368f May 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 left review comments

@evenyag evenyag evenyag approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@waynexia waynexia Awaiting requested review from waynexia waynexia is a code owner

@zhongzc zhongzc Awaiting requested review from zhongzc

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to flush physical metric table
4 participants
@WenyXu @killme2008 @fengjiachun @evenyag