Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support table level comment #4042

Merged
merged 2 commits into from
May 27, 2024
Merged

feat: support table level comment #4042

merged 2 commits into from
May 27, 2024

Conversation

irenjj
Copy link
Collaborator

@irenjj irenjj commented May 25, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close: #3836

What's changed and what's your intention?

support table level comment

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@irenjj irenjj requested a review from a team as a code owner May 25, 2024 08:56
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 25, 2024
@irenjj irenjj mentioned this pull request May 25, 2024
Merged
2 tasks
@codecov Codecov
Copy link

codecov bot commented May 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (5df3d4e) to head (a8a863f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4042      +/-   ##
==========================================
- Coverage   85.42%   85.14%   -0.29%     
==========================================
  Files         983      983              
  Lines      170493   170494       +1     
==========================================
- Hits       145652   145160     -492     
- Misses      24841    25334     +493

killme2008
killme2008 approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/operator/src/statement/ddl.rs Outdated Show resolved Hide resolved
tisonkun
tisonkun approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tisonkun tisonkun enabled auto-merge May 27, 2024 02:08
@tisonkun
use constants
a8a863f 
Signed-off-by: tison <[email protected]>
@tisonkun tisonkun added this pull request to the merge queue May 27, 2024
Merged via the queue into GreptimeTeam:main with commit 25d6425 May 27, 2024
28 checks passed
@irenjj irenjj deleted the table_level_comment branch May 27, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@killme2008 killme2008 killme2008 approved these changes

@shuiyisong shuiyisong Awaiting requested review from shuiyisong

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support table level comment
3 participants
@irenjj @killme2008 @tisonkun