Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(log_store): remove associated type Namespace and Entry in LogStore #4038

Merged
merged 33 commits into from
May 29, 2024
Merged

refactor(log_store): remove associated type Namespace and Entry in LogStore #4038

merged 33 commits into from
May 29, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 24, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4026
close #4043

What's changed and what's your intention?

  1. Remove the associated type Namespace and Entry in the LogStore trait
  2. Change KafkaLogStore's read method behavior. Let the read method return entries in the namespace(instead of entries belonging to a specific region)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested review from v0y4g3r, evenyag, waynexia and a team as code owners May 24, 2024 16:37
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 24, 2024
@WenyXu WenyXu mentioned this pull request May 24, 2024
Closed
7 tasks
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch from 03ff6f9 to 52ff0c4 Compare May 25, 2024 02:52
@codecov Codecov
Copy link

codecov bot commented May 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.45994% with 80 lines in your changes are missing coverage. Please review.

Project coverage is 85.05%. Comparing base (4aa756c) to head (9e3e9a5).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4038      +/-   ##
==========================================
- Coverage   85.33%   85.05%   -0.28%     
==========================================
  Files         987      987              
  Lines      171204   171485     +281     
==========================================
- Hits       146094   145856     -238     
- Misses      25110    25629     +519

@WenyXu WenyXu force-pushed the remove/log-store-namespace branch 2 times, most recently from 6df2aa1 to e955ba7 Compare May 25, 2024 03:20
@WenyXu WenyXu mentioned this pull request May 25, 2024
Merged
3 tasks
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch from 67c4696 to b1338c1 Compare May 25, 2024 09:14
@WenyXu WenyXu mentioned this pull request May 25, 2024
Closed
@WenyXu WenyXu requested a review from fengjiachun May 27, 2024 02:51
fengjiachun
fengjiachun reviewed May 27, 2024
View reviewed changes
src/log-store/src/kafka/log_store.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/log_store.rs Outdated Show resolved Hide resolved
src/log-store/src/raft_engine/log_store.rs Outdated Show resolved Hide resolved
@fengjiachun
Copy link
Collaborator

@v0y4g3r PTAL

@WenyXu WenyXu force-pushed the remove/log-store-namespace branch from 8e6619d to 0eaafa2 Compare May 28, 2024 02:59
v0y4g3r
v0y4g3r reviewed May 28, 2024
View reviewed changes
src/log-store/src/kafka/util/record.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/util/record.rs Show resolved Hide resolved
src/log-store/src/raft_engine/log_store.rs Outdated Show resolved Hide resolved
src/store-api/src/logstore/namespace.rs Outdated Show resolved Hide resolved
src/store-api/src/logstore/namespace.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as draft May 28, 2024 09:31
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch 3 times, most recently from 29c6338 to b2692ff Compare May 28, 2024 11:51
@WenyXu WenyXu marked this pull request as ready for review May 28, 2024 11:53
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch from b4a03e0 to 2d0214e Compare May 28, 2024 11:58
@WenyXu WenyXu changed the title refactor(log_store): remove associated type Namespace in LogStore refactor(log_store): remove associated type Namespace and Entry in LogStore May 28, 2024
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch 2 times, most recently from c7a8209 to 024e4e1 Compare May 28, 2024 13:54
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch 2 times, most recently from 2626078 to d756fd1 Compare May 28, 2024 15:46
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch from d756fd1 to 883b3fe Compare May 28, 2024 15:54
WenyXu
WenyXu commented May 28, 2024
View reviewed changes
src/log-store/src/kafka/log_store.rs Outdated Show resolved Hide resolved
src/log-store/src/kafka/log_store.rs Outdated Show resolved Hide resolved
WenyXu
WenyXu commented May 28, 2024
View reviewed changes
src/log-store/src/kafka/log_store.rs Show resolved Hide resolved
src/log-store/src/kafka.rs Show resolved Hide resolved
src/log-store/src/raft_engine.rs Show resolved Hide resolved
@WenyXu WenyXu mentioned this pull request May 29, 2024
Closed
v0y4g3r
v0y4g3r reviewed May 29, 2024
View reviewed changes
src/log-store/src/kafka/util/record.rs Show resolved Hide resolved
src/log-store/src/kafka/util/record.rs Show resolved Hide resolved
src/log-store/src/kafka/log_store.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/raw_entry_reader.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch from a24d9fd to 5a3dcef Compare May 29, 2024 08:47
evenyag
evenyag reviewed May 29, 2024
View reviewed changes
src/log-store/src/kafka/log_store.rs Show resolved Hide resolved
src/log-store/src/raft_engine/log_store.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/wal_entry_reader.rs Outdated Show resolved Hide resolved
src/store-api/src/logstore/entry.rs Show resolved Hide resolved
src/store-api/src/logstore/entry.rs Show resolved Hide resolved
src/store-api/src/storage/descriptors.rs Outdated Show resolved Hide resolved
@WenyXu WenyXu force-pushed the remove/log-store-namespace branch from c5a8c78 to 9e3e9a5 Compare May 29, 2024 13:07
v0y4g3r
v0y4g3r approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue May 29, 2024
Merged via the queue into GreptimeTeam:main with commit 6e9a9dc May 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun left review comments

@v0y4g3r v0y4g3r v0y4g3r approved these changes

@evenyag evenyag evenyag approved these changes

@waynexia waynexia Awaiting requested review from waynexia waynexia is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider ignoring existing corrupted data instead of throwing an error
4 participants
@WenyXu @fengjiachun @v0y4g3r @evenyag