Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove one clone on constructing partition #4028

Merged
merged 1 commit into from
May 24, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

String::from_utf8_lossy and serde_json::from_str are not in-place operations. It's not necessary to clone it and use by ref.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@waynexia waynexia requested a review from a team as a code owner May 24, 2024 03:41
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 24, 2024
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge May 24, 2024 03:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (a3a2c8d) to head (fee8141).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4028      +/-   ##
==========================================
- Coverage   85.45%   85.16%   -0.30%     
==========================================
  Files         980      980              
  Lines      170181   170181              
==========================================
- Hits       145435   144935     -500     
- Misses      24746    25246     +500     

@waynexia waynexia added this pull request to the merge queue May 24, 2024
Merged via the queue into GreptimeTeam:main with commit 0101657 May 24, 2024
29 checks passed
@waynexia waynexia deleted the remove-partition-clone branch May 24, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants