Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RawEntryReader and OneshotWalEntryReader trait #4027

Merged
merged 3 commits into from
May 24, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 24, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

#4026

What's changed and what's your intention?

Add RawEntryReader and OneShotWalEntryReader trait

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 24, 2024
@evenyag evenyag changed the title feat: add RawEntryReader and OneShotWalEntryReader trait feat: add RawEntryReader and OneshotWalEntryReader trait May 24, 2024
src/mito2/src/wal/raw_entry_reader.rs Outdated Show resolved Hide resolved
src/mito2/src/wal/raw_entry_reader.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 85.13%. Comparing base (a3a2c8d) to head (a3155e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4027      +/-   ##
==========================================
- Coverage   85.45%   85.13%   -0.32%     
==========================================
  Files         980      980              
  Lines      170181   170221      +40     
==========================================
- Hits       145435   144926     -509     
- Misses      24746    25295     +549     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r enabled auto-merge May 24, 2024 06:30
@v0y4g3r v0y4g3r added this pull request to the merge queue May 24, 2024
Merged via the queue into GreptimeTeam:main with commit 466f7c6 May 24, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants