Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log error for detail #4011

Merged
merged 2 commits into from
May 22, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

As the title said.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 22, 2024
@waynexia
Copy link
Member

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (9800807) to head (2f19846).
Report is 2 commits behind head on main.

Current head 2f19846 differs from pull request most recent head d80d6d3

Please upload reports for the commit d80d6d3 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4011      +/-   ##
==========================================
- Coverage   85.48%   85.16%   -0.33%     
==========================================
  Files         977      977              
  Lines      169462   169519      +57     
==========================================
- Hits       144859   144365     -494     
- Misses      24603    25154     +551     

@fengjiachun fengjiachun added this pull request to the merge queue May 22, 2024
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into GreptimeTeam:main with commit 418090b May 22, 2024
27 checks passed
@fengjiachun fengjiachun deleted the feat/log-error-detail branch May 22, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants