Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ttl to write_cache #4010

Merged
merged 5 commits into from
May 22, 2024

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As title suggests.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@shuiyisong shuiyisong requested review from evenyag, v0y4g3r, waynexia and a team as code owners May 22, 2024 04:23
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 22, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.15%. Comparing base (e070ba3) to head (8dfa055).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4010      +/-   ##
==========================================
- Coverage   85.47%   85.15%   -0.32%     
==========================================
  Files         977      977              
  Lines      169412   169519     +107     
==========================================
- Hits       144800   144355     -445     
- Misses      24612    25164     +552     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

src/mito2/src/cache/file_cache.rs Outdated Show resolved Hide resolved
src/mito2/src/cache/file_cache.rs Outdated Show resolved Hide resolved
tests-integration/tests/http.rs Show resolved Hide resolved
@shuiyisong shuiyisong enabled auto-merge May 22, 2024 06:39
@shuiyisong shuiyisong added this pull request to the merge queue May 22, 2024
Merged via the queue into GreptimeTeam:main with commit 9e1af79 May 22, 2024
36 checks passed
@shuiyisong shuiyisong deleted the chore/add_ttl_to_write_cache branch May 22, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants