-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manual compaction #3988
feat: manual compaction #3988
Conversation
We need to add restrictions to this types functions to avoid cross-catalog invocation. |
e48d097
to
a71c79f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3988 +/- ##
==========================================
- Coverage 85.48% 85.15% -0.33%
==========================================
Files 977 980 +3
Lines 169462 170113 +651
==========================================
Hits 144859 144859
- Misses 24603 25254 +651 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the permission perspective
1f60210
to
01830b5
Compare
01830b5
to
50a4397
Compare
By the way, I remember we have an http api the flush tables, is it removed? |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
This PR adds support for manually trigger different types of compactions.
The syntax is:
Currently,
compact_type
supportsregular
andstrict_window
.regular
: regular compaction like those triggered by flush.strict_window
: split SST files strictly by time window.The
<options>
argument is type-sepecific compaction options. Forstrict_window
, the option value is the compaction window in seconds.Checklist