-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make the command entry cleaner #3981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3981 +/- ##
==========================================
- Coverage 85.40% 85.13% -0.28%
==========================================
Files 978 977 -1
Lines 169100 169089 -11
==========================================
- Hits 144427 143951 -476
- Misses 24673 25138 +465 |
MichaelScofield
approved these changes
May 20, 2024
evenyag
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
May 21, 2024
* refactor: move run() in App trait * refactor: introduce AppBuilder trait * chore: remove AppBuilder * refactor: remove Options struct and make the start() clean * refactor: init once for common_telemetry::init_global_logging
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
NOTE: The PR is decoupled with draft PR #3941, and it's just a simple refactoring based on the original implementation.
Remove
Options{}
and some related methods, and all the building process of options can be in their app(for example,datanode.rs
/metasrv.rs
/...);Remove
SubCommand.build()
andSubCommand.load_options()
which are unnecessary;Move
common_telemetry::init_global_logging
into<app>:build()
which can be easy to receive the arguments;Move
start_app()
intoApp
and renamerun()
;Make
common_telemetry::init_global_logging
init once, or it will fail in integration test (what an ugly function...);Checklist