Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): expire arrange according to time_index type #3956

Merged
merged 2 commits into from
May 16, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented May 16, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

set arrangement's expire time with TypedPlan's time index

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Set arrangement's expire time with TypedPlan's time index
  • Added expire when to dataflow's state, so render_reduce can access it and set arrangement to expire accordingly

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 16, 2024
@discord9 discord9 marked this pull request as ready for review May 16, 2024 09:23
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 44.11765% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 85.31%. Comparing base (9f4a6c6) to head (5a1293b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3956      +/-   ##
==========================================
- Coverage   85.64%   85.31%   -0.34%     
==========================================
  Files         973      973              
  Lines      167045   167077      +32     
==========================================
- Hits       143073   142535     -538     
- Misses      23972    24542     +570     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue May 16, 2024
Merged via the queue into GreptimeTeam:main with commit a45017a May 16, 2024
23 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants