Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): avg func rewrite to sum/count #3955

Merged
merged 6 commits into from
May 16, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented May 16, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

added avg functino support

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • added avg function support, which will be rewrite to sum(x)/count(x) if count(x)!=0
  • fix aggr func's signature's output type to be the real evaled type(i.e. SumUInt* -> u64, SumInt* -> i64)

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 16, 2024
@discord9 discord9 force-pushed the flow_p2_avg_func branch 2 times, most recently from 4e1c5e1 to 21eeda2 Compare May 16, 2024 07:16
@discord9 discord9 marked this pull request as ready for review May 16, 2024 08:36
@discord9 discord9 changed the title Flow p2 avg func feat(flow): avg func rewrite to sum/count May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 94.64720% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 85.37%. Comparing base (9f4a6c6) to head (426c742).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3955      +/-   ##
==========================================
- Coverage   85.64%   85.37%   -0.28%     
==========================================
  Files         973      973              
  Lines      167045   167411     +366     
==========================================
- Hits       143073   142931     -142     
- Misses      23972    24480     +508     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@fengjiachun fengjiachun added this pull request to the merge queue May 16, 2024
Merged via the queue into GreptimeTeam:main with commit 93f178f May 16, 2024
26 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants