Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): add types for every plan enum variant #3938

Merged
merged 2 commits into from
May 14, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented May 14, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Added types(RelationType) for every flow plan's variant

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Added type info to every plan enum, and also add typ() for ScalarExpr so to determine expressions' types

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 14, 2024
@discord9 discord9 force-pushed the flow_refactor_typed_plan_expr branch from cb46f27 to 4e74bde Compare May 14, 2024 08:52
@discord9 discord9 marked this pull request as ready for review May 14, 2024 08:53
@discord9 discord9 requested review from zhongzc, waynexia and a team as code owners May 14, 2024 08:53
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 87.75510% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 85.35%. Comparing base (a260ba3) to head (d2ec8b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3938      +/-   ##
==========================================
- Coverage   85.65%   85.35%   -0.30%     
==========================================
  Files         967      967              
  Lines      165865   165999     +134     
==========================================
- Hits       142069   141687     -382     
- Misses      23796    24312     +516     

@discord9 discord9 added this pull request to the merge queue May 14, 2024
Merged via the queue into GreptimeTeam:main with commit 4ca7ac7 May 14, 2024
21 checks passed
@discord9 discord9 deleted the flow_refactor_typed_plan_expr branch May 14, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants