Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate orc-rs to datafusion-orc #3923

Merged
merged 1 commit into from
May 13, 2024

Conversation

realtaobo
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

close #3597

What's changed and what's your intention?

as title

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@realtaobo realtaobo requested a review from a team as a code owner May 13, 2024 03:05
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.69%. Comparing base (6ab3aeb) to head (0dec8b4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3923      +/-   ##
==========================================
- Coverage   86.00%   85.69%   -0.31%     
==========================================
  Files         963      963              
  Lines      164516   164509       -7     
==========================================
- Hits       141489   140976     -513     
- Misses      23027    23533     +506     

Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue May 13, 2024
Merged via the queue into GreptimeTeam:main with commit a0be719 May 13, 2024
22 checks passed
@realtaobo realtaobo deleted the upgradOrc branch May 13, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate "orc-rs" to "datafusion-orc"
3 participants