Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement the CompositeTableRoute #3918

Merged
merged 2 commits into from
May 11, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented May 11, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  1. Implement the CompositeTableRoute

The CompositeTableRoute stores all level routes of a table:

  • Stores PhysicalTableRouteValue for logical table.
  • Stores LogicalTableRouteValue, PhysicalTableRouteValue for the logical table.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@WenyXu WenyXu requested a review from fengjiachun May 11, 2024 07:52
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 92.48826% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 85.65%. Comparing base (fa6c371) to head (c2b7877).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3918      +/-   ##
==========================================
- Coverage   85.97%   85.65%   -0.33%     
==========================================
  Files         961      961              
  Lines      164471   164455      -16     
==========================================
- Hits       141409   140861     -548     
- Misses      23062    23594     +532     

@WenyXu WenyXu requested a review from waynexia May 11, 2024 08:42
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue May 11, 2024
Merged via the queue into GreptimeTeam:main with commit 27e376e May 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants