Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metaclient builder options with role #3909

Merged

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented May 10, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

There are too many options in MetaClient, but the configurations for the same roles when building MetaClient are almost identical. Therefore, it would be better to provide default options for different roles.

Closes #3660

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@fengjiachun fengjiachun requested review from MichaelScofield and a team as code owners May 10, 2024 12:31
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 10, 2024
@fengjiachun fengjiachun force-pushed the feat/buid-metaclient-with-role branch from 354a492 to 24fe446 Compare May 10, 2024 12:36
@fengjiachun fengjiachun requested a review from WenyXu May 10, 2024 12:37
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.65%. Comparing base (c91132b) to head (45b2a25).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3909      +/-   ##
==========================================
- Coverage   86.05%   85.65%   -0.40%     
==========================================
  Files         959      961       +2     
  Lines      164279   164555     +276     
==========================================
- Hits       141367   140957     -410     
- Misses      22912    23598     +686     

@fengjiachun fengjiachun added this pull request to the merge queue May 11, 2024
Merged via the queue into GreptimeTeam:main with commit fa6c371 May 11, 2024
21 checks passed
@fengjiachun fengjiachun deleted the feat/buid-metaclient-with-role branch May 11, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: refactor all metaclient's options by using node Role.
3 participants