Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metasrv start time to node info #3883

Merged
merged 1 commit into from
May 9, 2024

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Add start time to metasrv's node info.

Before:
image

After:
image

proto: GreptimeTeam/greptime-proto#167

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Cargo.toml Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 85.31%. Comparing base (0e05f85) to head (459b9af).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3883      +/-   ##
==========================================
- Coverage   85.65%   85.31%   -0.35%     
==========================================
  Files         952      952              
  Lines      163607   163611       +4     
==========================================
- Hits       140145   139584     -561     
- Misses      23462    24027     +565     

@fengjiachun fengjiachun enabled auto-merge May 9, 2024 06:39
@fengjiachun fengjiachun added this pull request to the merge queue May 9, 2024
Merged via the queue into GreptimeTeam:main with commit 7de62ef May 9, 2024
22 checks passed
@fengjiachun fengjiachun deleted the feat/metsrv-starttime branch May 9, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants