Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flow): mirror insert req to flow node #3858

Merged
merged 11 commits into from
May 6, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented May 6, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

  • Add a path in do_request of Inserter to allow copy source table insert requests and send to flow node
  • Also added TableFlowManager field in Inserter to allow query which insert request should go which flownode, but since we only have standalone flownode for now, they are mostly blanket impl
  • Some minor refactor, including Flownode handle_request change to handle_requests for batching request, and add XXXRef for Flow related managers.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@discord9 discord9 requested review from MichaelScofield and a team as code owners May 6, 2024 04:32
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 6, 2024
@discord9 discord9 requested review from zhongzc and WenyXu May 6, 2024 04:33
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 85.26%. Comparing base (73fe075) to head (e392fce).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3858      +/-   ##
==========================================
- Coverage   85.60%   85.26%   -0.35%     
==========================================
  Files         955      952       -3     
  Lines      163262   163077     -185     
==========================================
- Hits       139761   139044     -717     
- Misses      23501    24033     +532     

@discord9 discord9 requested a review from v0y4g3r May 6, 2024 09:19
@discord9 discord9 added this pull request to the merge queue May 6, 2024
Merged via the queue into GreptimeTeam:main with commit 573c19b May 6, 2024
21 checks passed
@discord9 discord9 deleted the flow_p3_mirror_request branch May 6, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants