Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: physical optimizer RemoveDuplicate to remove duplicate exec plans #3839

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

A tiny physical rule to remove useless adjoining plans.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@waynexia waynexia requested review from evenyag and a team as code owners April 29, 2024 13:40
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.33%. Comparing base (336db38) to head (075e667).
Report is 1 commits behind head on main.

❗ Current head 075e667 differs from pull request most recent head a7d703f. Consider uploading reports for the commit a7d703f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3839      +/-   ##
==========================================
- Coverage   85.78%   85.33%   -0.46%     
==========================================
  Files         950      955       +5     
  Lines      162714   163135     +421     
==========================================
- Hits       139582   139205     -377     
- Misses      23132    23930     +798     

Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia enabled auto-merge April 29, 2024 14:12
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I have a few questions, may you take a look? Thank you.

src/query/src/optimizer/remove_duplicate.rs Show resolved Hide resolved
src/query/src/optimizer/remove_duplicate.rs Show resolved Hide resolved
@waynexia waynexia added this pull request to the merge queue Apr 30, 2024
Merged via the queue into GreptimeTeam:main with commit a0f4881 Apr 30, 2024
20 checks passed
@waynexia waynexia deleted the remove_duplicate branch April 30, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants