Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: always obsolete wal to avoid discontinuous log entries #3789

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Apr 24, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This changes the behavior during datanode startup in that it will always obsolete wal log entries to flushed_entry_id in manifest so that if it can tolerate inserts when the entry id span in logstore < flushed_entry_id.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 24, 2024
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.24%. Comparing base (20a933e) to head (7adc350).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3789      +/-   ##
==========================================
- Coverage   85.55%   85.24%   -0.32%     
==========================================
  Files         947      947              
  Lines      160481   160476       -5     
==========================================
- Hits       137307   136791     -516     
- Misses      23174    23685     +511     

@v0y4g3r v0y4g3r added this pull request to the merge queue Apr 24, 2024
Merged via the queue into GreptimeTeam:main with commit 8d229dd Apr 24, 2024
18 checks passed
@v0y4g3r v0y4g3r deleted the feat/always-obsolete-wal-entries branch April 24, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants