Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider both db param and extended db header in Prometheus HTTP API #3776

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Closes #3497

What's changed and what's your intention?

Except #3497, this patch also fixes the behavior that db from params cannot override x-greptime-db-name header.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@waynexia waynexia requested a review from a team as a code owner April 23, 2024 06:39
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 23, 2024
@waynexia waynexia enabled auto-merge April 23, 2024 06:43
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.19%. Comparing base (bf21527) to head (0ddbd95).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3776      +/-   ##
==========================================
- Coverage   85.53%   85.19%   -0.35%     
==========================================
  Files         946      946              
  Lines      159564   159621      +57     
==========================================
- Hits       136489   135988     -501     
- Misses      23075    23633     +558     

@waynexia waynexia added this pull request to the merge queue Apr 23, 2024
@killme2008 killme2008 removed this pull request from the merge queue due to a manual request Apr 23, 2024
Signed-off-by: Ruihang Xia <[email protected]>
@killme2008 killme2008 added this pull request to the merge queue Apr 23, 2024
Merged via the queue into GreptimeTeam:main with commit f764fd5 Apr 23, 2024
19 checks passed
@waynexia waynexia deleted the prom-http-db branch April 23, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only have the numbers table on "metric" drop menu
4 participants