Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not remove deletion markers when window time range overlaps #3773

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Apr 22, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR disables deletion marker removal when some window's time range overlaps with another window, so that deletion markers will not be removed, which may cause deleted rows appear again.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 22, 2024
src/mito2/src/compaction/twcs.rs Outdated Show resolved Hide resolved
src/mito2/src/compaction/twcs.rs Outdated Show resolved Hide resolved
@v0y4g3r v0y4g3r requested a review from evenyag April 23, 2024 06:57
@v0y4g3r v0y4g3r marked this pull request as ready for review April 23, 2024 07:16
@v0y4g3r v0y4g3r requested a review from waynexia as a code owner April 23, 2024 07:16
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 97.65886% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 85.23%. Comparing base (8f2ce4a) to head (2b4a00c).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3773      +/-   ##
==========================================
- Coverage   85.57%   85.23%   -0.34%     
==========================================
  Files         945      946       +1     
  Lines      159357   159872     +515     
==========================================
- Hits       136364   136268      -96     
- Misses      22993    23604     +611     

@v0y4g3r v0y4g3r added this pull request to the merge queue Apr 23, 2024
Merged via the queue into GreptimeTeam:main with commit 778e195 Apr 23, 2024
33 checks passed
@v0y4g3r v0y4g3r deleted the fix/keep-deletion-marker branch April 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants