Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: secrets.GITHUB_TOKEN not exist on self-hosted runner #3765

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Error: C:\a\greptimedb\greptimedb\./.github/actions/build-windows-artifacts\action.yml (Line: 30, Col: 21): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN

This default secrets doesn't exist on self-hosted runner. The TOKEN is mainly for avoid rate limitation, but that may not be quite an issue for self-hosted daily cronjob. Remove firstly to unlock the workflow. We can revisit this topic if the rate limit comes back to be an issue.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@tisonkun tisonkun requested a review from a team as a code owner April 22, 2024 03:49
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.52%. Comparing base (8f2ce4a) to head (2d2a790).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3765      +/-   ##
==========================================
- Coverage   85.57%   85.52%   -0.05%     
==========================================
  Files         945      945              
  Lines      159357   159357              
==========================================
- Hits       136364   136290      -74     
- Misses      22993    23067      +74     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 7ca0fa5 Apr 22, 2024
20 checks passed
@evenyag evenyag deleted the tisonkun-patch-1 branch April 22, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants