fix test clippy

Signed-off-by: Ruihang Xia <[email protected]>

src/auth/src/tests.rs

@@ -45,9 +45,9 @@ impl Default for MockUserProvider {
 
 impl MockUserProvider {
  pub fn set_authorization_info(&mut self, info: DatabaseAuthInfo) {
- self.catalog = info.catalog.to_owned();
- self.schema = info.schema.to_owned();
- self.username = info.username.to_owned();
+ info.catalog.clone_into(&mut self.catalog);
+ info.schema.clone_into(&mut self.schema);
+ info.username.clone_into(&mut self.username);
  }
 }
 

src/common/meta/src/wal_options_allocator.rs

@@ -163,7 +163,7 @@ mod tests {
  let kv_backend = Arc::new(MemoryKvBackend::new()) as KvBackendRef;
  let mut topic_manager = KafkaTopicManager::new(config.clone(), kv_backend);
  // Replaces the default topic pool with the constructed topics.
- topic_manager.topic_pool = topics.clone();
+ topic_manager.topic_pool.clone_from(&topics);
  // Replaces the default selector with a round-robin selector without shuffled.
  topic_manager.topic_selector = Arc::new(RoundRobinTopicSelector::default());
 

src/common/meta/src/wal_options_allocator/kafka/topic_manager.rs

@@ -291,7 +291,7 @@ mod tests {
  let kv_backend = Arc::new(MemoryKvBackend::new()) as KvBackendRef;
  let mut manager = TopicManager::new(config.clone(), kv_backend);
  // Replaces the default topic pool with the constructed topics.
- manager.topic_pool = topics.clone();
+ manager.topic_pool.clone_from(&topics);
  // Replaces the default selector with a round-robin selector without shuffled.
  manager.topic_selector = Arc::new(RoundRobinTopicSelector::default());
  manager.start().await.unwrap();

src/common/time/src/timestamp.rs

@@ -1065,7 +1065,7 @@ mod tests {
  let (sec, nsec) = Timestamp::new(i64::MIN, TimeUnit::Nanosecond).split();
  let time = DateTime::from_timestamp(sec, nsec).unwrap().naive_utc();
  assert_eq!(sec, time.and_utc().timestamp());
- assert_eq!(nsec, time.timestamp_subsec_nanos());
+ assert_eq!(nsec, time.and_utc().timestamp_subsec_nanos());
  }
 
  #[test]

src/meta-client/src/client.rs

@@ -510,9 +510,6 @@ impl MetaClient {
 #[cfg(test)]
 mod tests {
  use api::v1::meta::{HeartbeatRequest, Peer};
- use meta_srv::metasrv::SelectorContext;
- use meta_srv::selector::{Namespace, Selector, SelectorOptions};
- use meta_srv::Result as MetaResult;
 
  use super::*;
  use crate::{error, mocks};
@@ -662,36 +659,6 @@ mod tests {
  });
  }
 
- struct MockSelector;
-
- #[async_trait::async_trait]
- impl Selector for MockSelector {
- type Context = SelectorContext;
- type Output = Vec<Peer>;
-
- async fn select(
- &self,
- _ns: Namespace,
- _ctx: &Self::Context,
- _opts: SelectorOptions,
- ) -> MetaResult<Self::Output> {
- Ok(vec![
- Peer {
- id: 0,
- addr: "peer0".to_string(),
- },
- Peer {
- id: 1,
- addr: "peer1".to_string(),
- },
- Peer {
- id: 2,
- addr: "peer2".to_string(),
- },
- ])
- }
- }
-
  #[tokio::test]
  async fn test_range_get() {
  let tc = new_client("test_range_get").await;

src/meta-srv/src/selector/load_based.rs

@@ -205,11 +205,9 @@ mod tests {
  let alive_stat_kvs = filter_out_expired_datanode(stat_kvs, &lease_kvs);
 
  assert_eq!(1, alive_stat_kvs.len());
- assert!(alive_stat_kvs
- .get(&StatKey {
- cluster_id: 1,
- node_id: 1
- })
- .is_some());
+ assert!(alive_stat_kvs.contains_key(&StatKey {
+ cluster_id: 1,
+ node_id: 1
+ }));
  }
 }

src/metric-engine/src/engine/create.rs

@@ -557,12 +557,12 @@ mod test {
 
  let mut options = HashMap::new();
  options.insert(PHYSICAL_TABLE_METADATA_KEY.to_string(), "value".to_string());
- request.options = options.clone();
+ request.options.clone_from(&options);
  let result = MetricEngineInner::verify_region_create_request(&request);
  assert!(result.is_ok());
 
  options.insert(LOGICAL_TABLE_METADATA_KEY.to_string(), "value".to_string());
- request.options = options.clone();
+ request.options.clone_from(&options);
  let result = MetricEngineInner::verify_region_create_request(&request);
  assert!(result.is_err());
 
@@ -620,14 +620,14 @@ mod test {
  data_region_request.primary_key,
  vec![ReservedColumnId::table_id(), ReservedColumnId::tsid(), 1]
  );
- assert!(data_region_request.options.get("ttl").is_some());
+ assert!(data_region_request.options.contains_key("ttl"));
 
  // check create metadata region request
  let metadata_region_request = engine_inner.create_request_for_metadata_region(&request);
  assert_eq!(
  metadata_region_request.region_dir,
  "/test_dir/metadata/".to_string()
  );
- assert!(metadata_region_request.options.get("ttl").is_none());
+ assert!(!metadata_region_request.options.contains_key("ttl"));
  }
 }

src/mito2/src/region/options.rs

@@ -440,7 +440,7 @@ mod tests {
  // No need to add compatible tests for RegionOptions since the above tests already check for compatibility.
  #[test]
  fn test_with_any_wal_options() {
- let all_wal_options = vec![
+ let all_wal_options = [
  WalOptions::RaftEngine,
  WalOptions::Kafka(KafkaWalOptions {
  topic: "test_topic".to_string(),

src/mito2/src/sst/parquet/row_selection.rs

@@ -82,7 +82,7 @@ mod tests {
 
  #[test]
  fn test_non_contiguous_ranges() {
- let ranges = vec![1..3, 5..8];
+ let ranges = [1..3, 5..8];
  let (selection, skipped) = row_selection_from_row_ranges(ranges.iter().cloned(), 10);
  let expected = RowSelection::from(vec![
  RowSelector::skip(1),
@@ -96,7 +96,7 @@ mod tests {
 
  #[test]
  fn test_empty_range() {
- let ranges = vec![];
+ let ranges = [];
  let (selection, skipped) = row_selection_from_row_ranges(ranges.iter().cloned(), 10);
  let expected = RowSelection::from(vec![]);
  assert_eq!(selection, expected);
@@ -105,7 +105,7 @@ mod tests {
 
  #[test]
  fn test_adjacent_ranges() {
- let ranges = vec![1..2, 2..3];
+ let ranges = [1..2, 2..3];
  let (selection, skipped) = row_selection_from_row_ranges(ranges.iter().cloned(), 10);
  let expected = RowSelection::from(vec![RowSelector::skip(1), RowSelector::select(2)]);
  assert_eq!(selection, expected);
@@ -114,7 +114,7 @@ mod tests {
 
  #[test]
  fn test_large_gap_between_ranges() {
- let ranges = vec![1..2, 100..101];
+ let ranges = [1..2, 100..101];
  let (selection, skipped) = row_selection_from_row_ranges(ranges.iter().cloned(), 10240);
  let expected = RowSelection::from(vec![
  RowSelector::skip(1),

src/query/src/tests/time_range_filter_test.rs

@@ -58,7 +58,7 @@ struct DataSourceWrapper {
 
 impl DataSource for DataSourceWrapper {
  fn get_stream(&self, request: ScanRequest) -> Result<SendableRecordBatchStream, BoxedError> {
- *self.filter.write().unwrap() = request.filters.clone();
+ self.filter.write().unwrap().clone_from(&request.filters);
  self.inner.get_stream(request)
  }
 }

src/table/src/predicate.rs

@@ -572,7 +572,7 @@ mod tests {
 
  let file = std::fs::OpenOptions::new()
  .write(true)
- .create(true)
+ .truncate(true)
  .open(path.clone())
  .unwrap();