Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid unnecessary cloning #3734

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Apr 18, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

It changes the behaviors to consume the bytes instead of cloning them.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 18, 2024
@WenyXu WenyXu requested a review from fengjiachun April 18, 2024 06:27
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (6494553) to head (a82448a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3734      +/-   ##
==========================================
- Coverage   85.44%   85.13%   -0.31%     
==========================================
  Files         966      966              
  Lines      162116   162218     +102     
==========================================
- Hits       138512   138107     -405     
- Misses      23604    24111     +507     

@MichaelScofield MichaelScofield added this pull request to the merge queue Apr 18, 2024
Merged via the queue into GreptimeTeam:main with commit 5107822 Apr 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants