Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove TableIdProvider #3733

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

As the title said, we do not need TableIdProvider any more.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@fengjiachun fengjiachun requested a review from a team as a code owner April 18, 2024 04:33
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 18, 2024
@tisonkun
Copy link
Contributor

@fengjiachun do we have any issue or previous PR associated? I suppose we remove the implementation elsewhere, or we have a tracking issue to do this refactor.

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (6494553) to head (7c17ce8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3733      +/-   ##
==========================================
- Coverage   85.44%   85.17%   -0.27%     
==========================================
  Files         966      966              
  Lines      162116   162214      +98     
==========================================
- Hits       138512   138159     -353     
- Misses      23604    24055     +451     

@MichaelScofield MichaelScofield added this pull request to the merge queue Apr 18, 2024
Merged via the queue into GreptimeTeam:main with commit 20e8c3d Apr 18, 2024
19 checks passed
@fengjiachun
Copy link
Collaborator Author

@fengjiachun do we have any issue or previous PR associated? I suppose we remove the implementation elsewhere, or we have a tracking issue to do this refactor.

https://github.com/GreptimeTeam/greptimedb/pull/2344/files#diff-aa097b6e60c9657813bde08112c91cdacd096a77c3f8478bb2087a7f3ad8751eL49

@fengjiachun fengjiachun deleted the chore/rm-unused-table-id-provider branch April 18, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants