-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tinytext, mediumtext and longtext data types #3731
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3731 +/- ##
==========================================
- Coverage 85.42% 85.15% -0.27%
==========================================
Files 966 966
Lines 162097 162116 +19
==========================================
- Hits 138472 138052 -420
- Misses 23625 24064 +439 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified locally also:
mysql> CREATE TABLE t(ts TIMESTAMP TIME INDEX, payload MEDIUMTEXT);
Query OK, 0 rows affected (0.02 sec)
mysql> DESC t;
+---------+----------------------+------+------+---------+---------------+
| Column | Type | Key | Null | Default | Semantic Type |
+---------+----------------------+------+------+---------+---------------+
| ts | TimestampMillisecond | PRI | NO | | TIMESTAMP |
| payload | String | | YES | | FIELD |
+---------+----------------------+------+------+---------+---------------+
2 rows in set (0.01 sec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution @CookiePieWw! This patch is clean and correct :D |
This reflects the change introduced by GreptimeTeam/greptimedb#3731.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #3703
What's changed and what's your intention?
Add
TINYTEXT
,MEDIUMTEXT
andLONGTEXT
as alias ofTEXT
for compatibility with MYSQL.Checklist