Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mito): set null value data size to i64 #3722

Merged
merged 2 commits into from
Apr 16, 2024
Merged

chore(mito): set null value data size to i64 #3722

merged 2 commits into from
Apr 16, 2024

Conversation

etolbakov
Copy link
Collaborator

@etolbakov etolbakov commented Apr 16, 2024 •
edited by tisonkun
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

This closes #3221

What's changed and what's your intention?

Assuming nulls occupy spaces we have opted to use the size of i64 as an initial approximation.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@etolbakov etolbakov requested a review from a team as a code owner April 16, 2024 14:17
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 16, 2024
evenyag
evenyag approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisonkun tisonkun enabled auto-merge April 16, 2024 14:36
@tisonkun tisonkun added this pull request to the merge queue Apr 16, 2024
Merged via the queue into GreptimeTeam:main with commit 89d5853 Apr 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun approved these changes

@evenyag evenyag evenyag approved these changes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mito: Null value should also contribute to memtable usage
3 participants
@etolbakov @evenyag @tisonkun