Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add filter_deleted option to avoid removing deletion markers #3707

Merged

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Apr 15, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

This PR adds an filter_deleted option to MergeReader so that it will not remove deletion markers (or tombstones) during merging.

filter_deleted is different from dedup in that:

  • If dedup is set to false, then filter_deleted will always be false since deletion markers are not expected to present.
  • If dedup is set to true, then filter_deleted decides whether deletion markers should be removed.

This PR is the predecessor work of #3702.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (bbea651) to head (dd840de).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3707      +/-   ##
==========================================
- Coverage   85.41%   85.11%   -0.31%     
==========================================
  Files         963      965       +2     
  Lines      160731   160989     +258     
==========================================
- Hits       137291   137024     -267     
- Misses      23440    23965     +525     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Apr 16, 2024
Merged via the queue into GreptimeTeam:main with commit 5af87ba Apr 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants