Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant try_flush invocations #3706

Merged

Conversation

tisonkun
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

This closes #2657.

What's changed and what's your intention?

TRIVIAL AS IS. Read the code and see #2657's description.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

@tisonkun tisonkun requested a review from WenyXu April 15, 2024 09:45
@tisonkun tisonkun requested a review from a team as a code owner April 15, 2024 09:45
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Apr 15, 2024
Signed-off-by: tison <[email protected]>
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.05%. Comparing base (8779524) to head (b03206e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3706      +/-   ##
==========================================
- Coverage   85.38%   85.05%   -0.33%     
==========================================
  Files         963      963              
  Lines      160719   160731      +12     
==========================================
- Hits       137231   136716     -515     
- Misses      23488    24015     +527     

@WenyXu WenyXu requested a review from v0y4g3r April 15, 2024 10:51
@MichaelScofield MichaelScofield added this pull request to the merge queue Apr 16, 2024
Merged via the queue into GreptimeTeam:main with commit cdbdb04 Apr 16, 2024
19 checks passed
@tisonkun tisonkun deleted the remove-redundant-try_flush branch April 16, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant try_flush invoking
3 participants