test: Add tests for KvBackend trait implement #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realtaobo
requested review from
v0y4g3r,
MichaelScofield and
a team
as code owners
github-actions
bot
added
Invalid PR Title
docs-not-required
realtaobo
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3700 +/- ##
==========================================
- Coverage 85.57% 85.23% -0.34%
==========================================
Files 962 963 +1
Lines 160274 160605 +331
==========================================
- Hits 137155 136898 -257
- Misses 23119 23707 +588 |
|
@realtaobo Thank you. There are some TOML format issues and cargo clippy warnings, could you fix them? |
tisonkun
reviewed
Apr 12, 2024
tisonkun
reviewed
Apr 13, 2024
tisonkun
reviewed
Apr 14, 2024
tisonkun
reviewed
Apr 14, 2024
There was a problem hiding this comment.
@realtaobo Please update the PR description for what behavior tests your added.
Reverse engineering and guess from the code is unfriendly for reviewers.
Got it. Finished. |
Signed-off-by: tison <[email protected]>
tisonkun
approved these changes
Apr 15, 2024
|
cc @MichaelScofield PTAL. |
WenyXu
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
close #2618
What's changed and what's your intention?
For now,
KvBackendtrait has some implements, such asChrootKvBackend,MemoryKvBackend, etc. But onlyRaftEngineBackend,MemoryKvBackendandEtcdStorewill directly access the data. PR #2615 has been added some tests forRaftEngineBackendandMemoryKvBackend, this PR forEtcdStoreto ensure all implements have the same behaviors.Other
KvBackendtrait implements basedRaftEngineBackend,MemoryKvBackendandEtcdStoreimplement，I think it's unnecessary.Tests mainly for range、put、batch_put、batch_get、compare_and_put、delete_range、batch_delete.
Checklist